fix: autorefresh should work after kernel shutdown#1011
Merged
nikophil merged 1 commit intozenstruck:2.xfrom Oct 20, 2025
Merged
fix: autorefresh should work after kernel shutdown#1011nikophil merged 1 commit intozenstruck:2.xfrom
nikophil merged 1 commit intozenstruck:2.xfrom
Conversation
nikophil
commented
Oct 20, 2025
| /** @param \Closure():self|self $configuration */ | ||
| public static function boot(\Closure|self $configuration): void | ||
| { | ||
| PersistedObjectsTracker::reset(); |
There was a problem hiding this comment.
Hello !
Looks like this change has side effect :
class FooTest extends WebTestCase
{
use Factories;
public function testFoo(): void
{
FooFactory::create();
}
}gives us
Error: Typed static property Zenstruck\Foundry\Persistence\Proxy\PersistedObjectsTracker::$buffer must not be accessed before initialization
/var/www/project/vendor/zenstruck/foundry/src/Persistence/Proxy/PersistedObjectsTracker.php:53
/var/www/project/vendor/zenstruck/foundry/src/Persistence/PersistenceManager.php:89
/var/www/project/vendor/zenstruck/foundry/src/Persistence/PersistentObjectFactory.php:266
/var/www/project/tests/Functional/FooTest.php:7
Is there anything special to do to initialize foundry with this new version ?
nikophil
force-pushed
the
fix/auto-refresh-after-kernel-shutdown
branch
from
c1b9ccb to
e666d2b
Compare
Closed
Contributor
|
Hey! I'm sorry for posting here, but it looks like this releases broke the Symfony UX tests-suite (https://github.com/symfony/ux/actions/runs/18675203003/job/53243634658?pr=3145), the test https://github.com/symfony/ux/blob/cd4dbe384bb4338a6ff9f384fdc6df7543e53db5/src/LiveComponent/tests/Functional/EventListener/LiveComponentSubscriberTest.php#L46-L73 is not passing anymore: Do you know what can happens? |
Member
Author
|
hi @Kocal I won't be able to fix this today 😬 Please add a conflict on this version in you repo, I'll fix this tomorrow |
Contributor
|
No problem, at least you know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1009